Restructure / implement more functionality#1
Open
mariogiov wants to merge 11 commits intonh13:masterfrom
Open
Conversation
Owner
There was a problem hiding this comment.
what if we want a specific sample within a project?
Author
There was a problem hiding this comment.
Agreed, I think the more restrictive use-case as you describe it is the better one.
Owner
|
Unfortunately, this breaks backwards compatibility with a common use case. If I have a project that is shared with me, it is not listed when I simply specify the project id using the to: Perhaps there is some default limit? Anyhow, looks good so far but the above needs to be fixed and I can continue reviewing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Nils!
I was looking for a good wrapper for downloading files from BaseSpace and I found your scripts! Great initiative. I think a good set of wrappers for additional functionality would be great. I rewrote this script pretty heavily (mostly just to be a bit more Pythonic) while keeping the general flow you had. I think the result is quite tidy but there are still some more features I'd like to add and some more restructuring as well. If you'd rather skip this PR that's fine but I think collaborations are always a good thing (and I love the ascii art!).
Best,
Mario